Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping an author of a commit that caused to fail the CI #693

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Conversation

pomek
Copy link
Member

@pomek pomek commented Mar 2, 2021

Suggested merge commit message (convention)

Feature (tests): The notify-travis-status script will mention an author of a commit that caused to fail the CI.


Additional information

More details about the implementation in the internal repo.

@coveralls
Copy link

coveralls commented Mar 2, 2021

Coverage Status

Coverage remained the same at 87.066% when pulling 769a01b on i/internal/651 into 22e4fb1 on master.

@mlewand mlewand self-requested a review March 8, 2021 07:26
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor rewording suggested.

@pomek there's one more action I see here - we need to make sure that onboarding instructions include a step with adding new dev to the introduced .json list.

Co-authored-by: Marek Lewandowski <mlewand@users.noreply.github.com>
@pomek pomek merged commit d0dcf25 into master Mar 8, 2021
@pomek pomek deleted the i/internal/651 branch March 8, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants