Make release tools asynchronous #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
changed the title
pomek
commented
May 15, 2023
packages/ckeditor5-dev-release-tools/lib/tasks/cleanuppackages.js
Outdated
Show resolved
Hide resolved
pomek
commented
May 15, 2023
pomek
commented
May 15, 2023
packages/ckeditor5-dev-release-tools/lib/tasks/updatedependencies.js
Outdated
Show resolved
Hide resolved
pomek
commented
May 15, 2023
packages/ckeditor5-dev-release-tools/lib/tasks/updateversions.js
Outdated
Show resolved
Hide resolved
martnpaneq
reviewed
May 16, 2023
|
|
||
| const counter = tools.createSpinner( processDescription, { total: packages.length } ); | ||
| counter.start(); | ||
| const onPackageDone = progressFactory( listrTask, packages.length ); |
There was a problem hiding this comment.
Looks like progressFactory could be passed as an argument to executeInParallel. This way executeInParallel would be independent of the task runner if we chose to use a different one in the future for other use cases.
The api could look somewhat like this
executeInParallel( {
packagesDirectory: 'packages',
progressFactory,
taskToExecute: () => {}
} );
function progressFactory( totalPackages ) {
let done = 0;
return () => {
done++;
listrTask.output = 'task finished. Total: ' + done + '/' + totalPackages;
};
}There was a problem hiding this comment.
I agree, but it's hard to predict what arguments it should receive. I would keep it in mind in the future to refactor it.
martnpaneq
reviewed
May 16, 2023
packages/ckeditor5-dev-release-tools/tests/tasks/updatedependencies.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Make release tools asynchronous. Closes ckeditor/ckeditor5#14135.