Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Aligned to changes in UI #12

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Aligned to changes in UI #12

merged 3 commits into from
Apr 5, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Mar 29, 2018

Suggested merge commit message (convention)

Internal: Aligned to changes in UI. See ckeditor/ckeditor5#742.

@pomek pomek requested a review from Reinmar March 29, 2018 10:39
@pomek pomek mentioned this pull request Mar 29, 2018
Merged
@pomek
Copy link
Member Author

pomek commented Mar 29, 2018

This PR requires ckeditor/ckeditor5-ui#382.

@coveralls
Copy link

coveralls commented Mar 29, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 55

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 30 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-68.2%) to 31.818%
Files with Coverage Reduction New Missed Lines %
src/decouplededitoruiview.js 1 83.33%
src/decouplededitor.js 12 42.86%
src/decouplededitorui.js 17 0.0%
Totals Coverage Status
Change from base Build 54: -68.2%
Covered Lines: 14
Relevant Lines: 44
💛 - Coveralls

@Reinmar Reinmar merged commit 799a6f0 into master Apr 5, 2018
@Reinmar Reinmar deleted the t/ckeditor5/742 branch April 5, 2018 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Reinmar Reinmar Reinmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pomek @coveralls @Reinmar