-
Notifications
You must be signed in to change notification settings - Fork 19
t/1: The first implementation of the decoupled editor #2
Conversation
* @returns {Promise} A promise resolved once the editor is ready. | ||
* The promise returns the created {@link module:editor-decoupled/decouplededitor~DecoupledEditor} instance. | ||
*/ | ||
static create( data, config ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid extending EditorConfig
with additional properties, I think that we could define DecoupledEditorConfig
as an extension of EditorConfig
and add them there.
* Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved. | ||
* For licensing, see LICENSE.md. | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it exist? Maybe a comment here? Or can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially that I can see something like this:
[ThemeImporter] Failed to find "/workspace/ckeditor5/packages/ckeditor5-theme-lark/theme/ckeditor5-editor-decoupled/decouplededitor.c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a post–copy&paste orphan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it and all seems to work fine.
tests/manual/decouplededitor.html
Outdated
</p> | ||
|
||
<h2>The toolbar</h2> | ||
<div class="toolbar-container ck-reset_all"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about .ck-reset_all
and .ck-reset
. Without them the editor doesn't look as it should. This is a pity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't the editor UI add these classes to the editable and the toolbar automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed (6393bf2) what seems to be a fix for it to me. We may also consider adding this class directly in ToolbarView.
Suggested merge commit message (convention)
Feature: The first implementation of the decoupled editor. Closes ckeditor/ckeditor5#2240. Closes ckeditor/ckeditor5#873.