Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection position in a post-fixer #4236

Closed
pjasiun opened this issue Jan 8, 2018 · 4 comments
Closed

Fix selection position in a post-fixer #4236

pjasiun opened this issue Jan 8, 2018 · 4 comments
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@pjasiun
Copy link

pjasiun commented Jan 8, 2018

Since now it should be possible to write also postfixes for selection, we should try to replace Schema.getNearestSelectionRange (moved from document) with a postfixer which will automatically move the selection to the proper place.

@pjasiun
Copy link
Author

pjasiun commented Jan 8, 2018

@Reinmar Reinmar changed the title Replace Schema.getNearestSelectionRange method with a postfixer Fix selection position in a post-fixer Jan 15, 2018
@Reinmar
Copy link
Member

Reinmar commented Jan 15, 2018

I changed the title of this ticket because it's not about replacing the existing method with something, but about creating a post-fixer. What happens with this method is a side topic.

@Reinmar
Copy link
Member

Reinmar commented Mar 19, 2018

@Reinmar
Copy link
Member

Reinmar commented Sep 4, 2018

I think it's done. @jodator's selection postfixer was needed for tables but it covered far more cases and fixed many issues.

@Reinmar Reinmar closed this as completed Sep 4, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added module:model type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants