Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split view selection into Selection & DocumentSelection #4279

Closed
pjasiun opened this issue Feb 16, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1357
Closed

Split view selection into Selection & DocumentSelection #4279

pjasiun opened this issue Feb 16, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1357
Labels
package:engine
Milestone
iteration 15

Comments

@pjasiun
Copy link

pjasiun commented Feb 16, 2018

Follow-up to #4222.

Some observers, like selection or mutation observers, create an instance of Selection and put it in the event. Now Selection is read-only so it can not be created nor modified without using a private API.

We should solve it the same way we do it the model: rename current Selection to DocumentSelection and introduce another Selection class, with public write API.
@pjasiun pjasiun assigned ma2ciek and szymonkups and unassigned ma2ciek Feb 16, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-typing Mar 19, 2018
Merge pull request #144 from ckeditor/t/ckeditor5-engine/1304
94079bd 
Internal: Using view.Selection public API. For more information see https://github.com/ckeditor/ckeditor5-engine/issues/1304.
pjasiun referenced this issue in ckeditor/ckeditor5-image Mar 19, 2018
Merge pull request #185 from ckeditor/t/ckeditor5-engine/1304
270311e 
Internal: Documentation update after view selection split. For more information see https://github.com/ckeditor/ckeditor5-engine/issues/1304.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Mar 19, 2018
Merge pull request #1357 from ckeditor/t/1304
b466e3f 
Other: View selection is now split onto Selection and DocumentSelection. Closes #1304 .

BREAKING CHANGE: Introduced view.DocumentSelection. It has protected API and can be modified only by view writer. Observers creating instance of selection (like SelectionObserver, MutationObserver) use view.Selection class now.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine
Projects
None yet
Milestone
iteration 15
Development

Successfully merging a pull request may close this issue.

View selection split into Selection and DocumentSelection ckeditor/ckeditor5-engine
4 participants
@pjasiun @szymonkups @ma2ciek @mlewand