Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline filler (ZWS) is removed while typing inside empty inline element #4340

Closed
f1ames opened this issue Apr 18, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1424
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@f1ames
Copy link
Contributor

f1ames commented Apr 18, 2018

I have completely changed this issue description, see why in https://github.com/ckeditor/ckeditor5-engine/issues/1409#issuecomment-391973289 below.

  1. Go to https://ckeditor5.github.io/.
  2. Replace whole content with Foo Bar and place selection on the end.
  3. Turn on Bold.
    • Now inline filler is inserted.
  4. Type something.
    • Inline filler is removed.

Expected

Inline filler is not removed until selection is moved from text node.

Actual

Inline filler is removed while typing inside empty inline element.

There are cases when it behaves correctly. Follow the below steps (also shown in below gif) to see how it should behave:

  1. Turn Bold off.
    • Now inline filler is inserted.
  2. Type something.
    • Inline filler is not removed.

filler

@f1ames
Copy link
Contributor Author

f1ames commented May 25, 2018

After investigating inline fillers and rendering behaviour a little more, it turned out that actually an expected behaviour was treated as a bug in this issue. The fact that inline filler is removed while typing inside empty inline elements is an actual issue (see https://github.com/ckeditor/ckeditor5-engine/issues/1342#issuecomment-391422791 and ckeditor/ckeditor5-engine#1355 (comment)) so the opposite to what was reported 🙃 I have adjusted the issue description.

@f1ames f1ames changed the title Inline filler (ZWS) is not removed after typing unbolded text on the end of the paragraph Inline filler (ZWS) is removed while typing inside empty inline element May 25, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-engine Jun 18, 2018
Fix: Renderer should avoid doing unnecessary DOM structure changes. Ensuring that the DOM gets updated less frequently fixes many issues with text composition. Closes #1417. Closes #1409. Closes #1349. Closes #1334. Closes #898. Closes ckeditor/ckeditor5-typing#129. Closes ckeditor/ckeditor5-typing#89. Closes #1427.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added module:view type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
2 participants