-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline filler (ZWS) is removed while typing inside empty inline element #4340
Comments
After investigating inline fillers and rendering behaviour a little more, it turned out that actually an expected behaviour was treated as a bug in this issue. The fact that inline filler is removed while typing inside empty inline elements is an actual issue (see https://github.com/ckeditor/ckeditor5-engine/issues/1342#issuecomment-391422791 and ckeditor/ckeditor5-engine#1355 (comment)) so the opposite to what was reported 🙃 I have adjusted the issue description. |
Fix: Renderer should avoid doing unnecessary DOM structure changes. Ensuring that the DOM gets updated less frequently fixes many issues with text composition. Closes #1417. Closes #1409. Closes #1349. Closes #1334. Closes #898. Closes ckeditor/ckeditor5-typing#129. Closes ckeditor/ckeditor5-typing#89. Closes #1427.
I have completely changed this issue description, see why in https://github.com/ckeditor/ckeditor5-engine/issues/1409#issuecomment-391973289 below.
Foo Bar
and place selection on the end.Bold
.Expected
Inline filler is not removed until selection is moved from text node.
Actual
Inline filler is removed while typing inside empty inline element.
There are cases when it behaves correctly. Follow the below steps (also shown in below gif) to see how it should behave:
Bold
off.The text was updated successfully, but these errors were encountered: