-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockquote implementation #3905
Comments
I'm also curious how's |
Besides, it's tricky to understand which rules are specific to blockquote and which are general and should land in the default algorithms. |
Btw, be sure to check Editor Recommendations on Quotes. |
Good point. Do we want to have a caption support? If so, then it's a far more complex feature than what we have in CKEditor 4. It may need to be implemented with a widget or some smart model operations. The latter would be a very interesting test for our data model, but I'm afraid that we don't have time for that now. We'd need to start this with a UX research too, cause I'm not sure how should the caption be reachable when vs how to escape blockquote. Perhaps it's a simple rule that enter in an empty paragraph in a blockquote removes that paragraph and moves selection out of the quote and below the caption. |
I talked with @fredck. We're going now with a CKEditor4 like implementation (but rendering to a |
When modifying selection in situation described in first comment will be implemented, it should also support objects. Widgets implemetation should also use it during <widget></widget><blockquote><p>[]</p></blockquote>
// backspace pressed
[<widget></widget>] <blockquote><p>[]</p></blockquote><widget></widget>
// delete pressed
[<widget></widget>] |
…positions where text can be placed. Covers most of #710 too.
I can see that So the problem with https://github.com/ckeditor/ckeditor5-block-quote/issues/7 lays inside |
Other: Changed the behavior of `DataController.deleteContent()` in a case of nested elements to better match situations like using <kbd>Backspace</kbd> after a block quotation. Closes #710.
This is an initial issue describing
Blockquote
feature implementation.There is no requirements list yet, but we already see that it will require some changes in the engine. Let's gather them here.
Add support for nested elements to
DataController#modifySelection
:Extending selection in situation like this:
should return:
The text was updated successfully, but these errors were encountered: