Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View -> model converter should return only DocumentFragment #4011

Closed
oskarwrobel opened this issue Mar 7, 2017 · 2 comments
Closed

View -> model converter should return only DocumentFragment #4011

oskarwrobel opened this issue Mar 7, 2017 · 2 comments
Labels
package:engine resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oskarwrobel
Copy link
Contributor

Follow-up: https://github.com/ckeditor/ckeditor5-engine/issues/787. See: ckeditor/ckeditor5-engine#845 (comment).

At the moment view -> model converter can return any type of data. Everything that is set as conversion output will be returned by the converter. This is kind of hidden feature which makes some part of code and tests confusing. We decided that only DocumentFragment will be returned by the converter.
@Reinmar
Copy link
Member

Reinmar commented Mar 20, 2017

Related issue: https://github.com/ckeditor/ckeditor5-engine/issues/742. Or... actually a DUP. Could you verify and close one of them?

@oskarwrobel
Copy link
Contributor Author

Yep it looks like DUP of https://github.com/ckeditor/ckeditor5-engine/issues/742

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added module:conversion resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Reinmar @oskarwrobel @mlewand