This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
PoC of how fake selection container can be skipped when diffing nodes #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… because FSC is never returned as part of the expected ones.
Reinmar
force-pushed
the
t/ckeditor5/1578b
branch
from
5f99446
to
a1607f3
Compare
|
I can reproduce both the original issue and this one https://github.com/ckeditor/ckeditor5-engine/issues/1685 testing this branch. They appear at random and I'm unable to figure out a repeatable reproduction path. |
|
I guess Olek experienced the same issue as @Mgsy in ckeditor/ckeditor5#1578 (comment). Can we close this PR? |
ckeditor/ckeditor5#1578 (comment) was the only issue I found, so there's 👍 from me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Filter out fake selection container before comparing DOM view root children in view renderer. Closes ckeditor/ckeditor5#1578.