This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
view.DowncastWriter#wrap() and #unwrap() fixes for nested attribute elements #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased with newest master |
|
Before we'll carry out the code review, I'll ask you @Mgsy to manual check whether this fix addresses issue reported ckediotr/ckeditor5-font#30. Also do some random smoke testing with the editor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix:
view.DowncastWriterwill now correctly wrap and unwrap nested attribute elements. Closes ckeditor/ckeditor5#4502. Closes ckeditor/ckeditor5#2288.