Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Active font color is now visible in both color grids #53

Merged
merged 5 commits into from
Aug 9, 2019
Merged

Active font color is now visible in both color grids #53

merged 5 commits into from
Aug 9, 2019

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Aug 8, 2019

Suggested merge commit message (convention)

Other: Active font color is now visible in both color grids. Closes ckeditor/ckeditor5#2299.


Additional information

@oleq oleq self-requested a review August 8, 2019 09:33
@coveralls
Copy link

coveralls commented Aug 8, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 506d0ee on t/51 into 552f742 on master.

tests/ui/colortableview.js Outdated Show resolved Hide resolved
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this bug:

2019-08-08 11-47-52 2019-08-08 11_48_59

@msamsel
Copy link
Contributor Author

msamsel commented Aug 8, 2019

@oleq source of this bug is in the ckeditor5-ui, because ColorGridView does not set up isOn value for newly added tiles. I add a PR for that: ckeditor/ckeditor5-ui#522.

@msamsel msamsel requested a review from oleq August 8, 2019 12:16
@oleq oleq merged commit 295f6d5 into master Aug 9, 2019
@oleq oleq deleted the t/51 branch August 9, 2019 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The active font color is only selected in the document colors
3 participants