Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Aligned to the changes in engine #22

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Aligned to the changes in engine #22

merged 1 commit into from
Apr 5, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Mar 29, 2018

Suggested merge commit message (convention)

Internal: Aligned to the changes in the engine. See ckeditor/ckeditor5#742.

Requires: ckeditor/ckeditor5-engine#1389.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6fe73b1 on t/ckeditor5/742 into 1069d44 on master.

@Reinmar
Copy link
Member

Reinmar commented Apr 4, 2018

For the future reference, cause I'm pretty sure I'll be wondering why we haven't changed the option.class to option.classes in this case.

The thing is that the option describes the class of the marker (like in the "class of problems"). It's the type of that marker. Not a generic property of some view element's definition.

@Reinmar Reinmar merged commit 50d7608 into master Apr 5, 2018
@Reinmar Reinmar deleted the t/ckeditor5/742 branch April 5, 2018 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants