Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/11: Fix indent block command on nested blocks. #15

Merged
merged 5 commits into from
Jul 24, 2019
Merged

T/11: Fix indent block command on nested blocks. #15

merged 5 commits into from
Jul 24, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Jul 17, 2019

Suggested merge commit message (convention)

Fix: The 'indentBlock' command will operate on top-most blocks. Closes ckeditor/ckeditor5#2348.


Additional information

@jodator jodator requested a review from mlewand July 17, 2019 14:07
@mlewand mlewand self-assigned this Jul 23, 2019
@jodator
Copy link
Contributor Author

jodator commented Jul 23, 2019

@mlewand I've rebased this as #14 is merged

Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine, just minor issues in unit tests and we're good to go 🏃‍♀️

tests/indentblockcommand.js Outdated Show resolved Hide resolved
tests/indentblockcommand.js Outdated Show resolved Hide resolved
tests/indentblockcommand.js Show resolved Hide resolved
@mlewand mlewand removed their assignment Jul 23, 2019
@mlewand mlewand self-assigned this Jul 24, 2019
@mlewand mlewand self-requested a review July 24, 2019 07:31
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👌

@mlewand mlewand merged commit 7fac8c0 into master Jul 24, 2019
@mlewand mlewand deleted the t/11 branch July 24, 2019 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation for table is applied to both the table and its content
2 participants