87: Toggle inspector on global ALT+F12 shortcut.

[jodator]

So I've implemented the toggling as you proposed in the issue - that was easy.

However, I have problem with tests, see f6f1a3a. In here I've added a home made window.addEventListener() interceptor, similarly to a one proposed here.

However, the test fails on assertion (the code is executed though).

---

Feature: Toggle inspector on Alt+F12 keyboard shortcut. Closes #87.

[oleq]

The issue with your test was that tests in this file use a mock redux data store which has a pass-through reducer so executing toggleIsCollapsed() does not change the store (store = createStore( ( state, action ) => ( { ...state, ...action.state } ), {).

All that needs to be asserted is the action dispatched on the store. What happens to the real production store on this particual action is asserted in different tests. The goal of these tests (all tests in the project) is decoupling data (store) and the view (react). 

In store tests we test the store stateA -> action dispatched on the store -> assert( store stateB ).

In component tests we test DOM event/user interaction -> assert( action type ) and fake store change -> assert( react component rendering).

I also noticed that the other test is broken (an aftermath of #94). If fixed it as well.

[oleq]

Have you checked if Alt+F12 works on all [Chrome, Firefox, Safari]x[Mac, Windows, popular linux WM] combinations?

[jodator]

Have you checked if Alt+F12 works on all [Chrome, Firefox, Safari]x[Mac, Windows, popular linux WM] combinations?

Nope. Good point. I'll check that and I'll add a better combination check - like we shouldn't act on ctrl+alt+F12.

Thanks for the explanation with tests.

[jodator]

So far I've checked Chrome,Firefox x Linux Mint (Ubuntu) as I don't have access to other browsers I've also searched the help.

Browsers:

• Chrome
• Firefox
• Safari

And OS'es:

• Mac OS
• Windows
• Ubuntu

AFAICS most of them doesn't use "higher" F, only F11 for maximize and F12 for developer tools in FF/Chrome - so without actually testing them I'm pretty OK with this shortcut.

[jodator]

@oleq so I've asked @mlewand to check alt+f12 on Windows, could you do the same for Mac?

[oleq]

It's safe.

[jodator]

@oleq Tahanks!

Also, I have a confirmation from @mlewand that on Windows x (FF, Chrome, Edge) that alt+f12 it is also safe.