Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make property CKEditorPremiumFeatures non-nullable if premium: true is passed #24

Closed
Mati365 opened this issue Sep 5, 2024 · 0 comments · Fixed by #25
Closed

Make property CKEditorPremiumFeatures non-nullable if premium: true is passed #24

Mati365 opened this issue Sep 5, 2024 · 0 comments · Fixed by #25
Milestone
iteration 78

Comments

@Mati365
Copy link
Member

Mati365 commented Sep 5, 2024 •
edited
Loading

Nothing critical, but it'll improve DX a bit. We need to adjust this line:

https://github.com/ckeditor/ckeditor5-integrations-common/blob/master/src/cdn/loadCKEditorCloud.ts#L117

To make it non-nullable if

premium: true is passed here:

https://github.com/ckeditor/ckeditor5-integrations-common/blob/master/src/cdn/loadCKEditorCloud.ts#L150

It may be a good idea to improve, ckbox typing too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iteration 78
Development

Successfully merging a pull request may close this issue.

Narrow typing of loadCKEditorCloud result ckeditor/ckeditor5-integrations-common
2 participants
@Mati365 @CKEditorBot