Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow typing of loadCKEditorCloud result #25

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Narrow typing of loadCKEditorCloud result #25

merged 4 commits into from
Sep 9, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Sep 6, 2024

Suggested merge commit message (convention)

Feature: CKEditorCloudResult now returns more narrowly typed attributes for CKBox and CKEditorPremiumFeatures, taking into account CKEditorCloudConfig. Closes #24

Additional info

const { CKEditorPremiumFeatures } = await loadCKEditorCloud( {
  version: '43.0.0',
  premium: true,
  ckbox: {
    version: '2.5.1'
  }
} );

Before:

CKEditorPremiumFeatures is nullable type.

After:

CKEditorPremiumFeatures is not nullable type because premium: true is passed.

@Mati365 Mati365 requested a review from pomek September 6, 2024 13:33
Copy link

@gorzelinski gorzelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types seem to work fine, so I only added suggestions to the comments.

@Mati365
Copy link
Member Author

Mati365 commented Sep 9, 2024

@gorzelinski done

@Mati365 Mati365 merged commit 30de408 into master Sep 9, 2024
5 checks passed
@Mati365 Mati365 deleted the ck/24 branch September 9, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make property CKEditorPremiumFeatures non-nullable if premium: true is passed
3 participants