Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the URL in the preview should not open a tab unless the widget is focused #2745

Closed
oleq opened this issue Aug 24, 2018 · 6 comments · Fixed by ckeditor/ckeditor5-media-embed#86
Assignees
Labels
package:media-embed type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@oleq
Copy link
Member

oleq commented Aug 24, 2018

A follow-up of https://github.com/ckeditor/ckeditor5-media-embed/issues/11, which introduced the tooltip for the URLs.

@Reinmar
Copy link
Member

Reinmar commented Aug 27, 2018

I'm for that because today I opened a link again instead of focusing the widget.

@scofalik
Copy link
Contributor

Makes a lot of sense. +1

@msamsel
Copy link
Contributor

msamsel commented May 20, 2019

I'm wonder, maybe this case should be more generic, like: "don't allow on interaction with not focused widget"?
WDYT?

cc @Reinmar, @mlewand

@mlewand
Copy link
Contributor

mlewand commented May 20, 2019

Well I don't mind tweets and similar embeds being implemented just like videos. Currently there's simply a pointer-events lock which does the trick.

@Reinmar
Copy link
Member

Reinmar commented May 28, 2019

I'm wonder, maybe this case should be more generic, like: "don't allow on interaction with not focused widget"?

I don't know of any other tickets about this. Right now we're dealing with this particular issue only.

@msamsel
Copy link
Contributor

msamsel commented May 28, 2019

I don't know of any other tickets about this. Right now we're dealing with this particular issue only.

I've proposed PR which fix only those cases after @mlewand point me really nice and neat solution.

oleq referenced this issue in ckeditor/ckeditor5-media-embed Jun 12, 2019
Clicking a media preview link should not open a new browser tab unless the media is already selected. Closes #18.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 25 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:media-embed labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:media-embed type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants