Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/53: Floated content and media widgets should not overlap #59

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Conversation

oleq
Copy link
Member

@oleq oleq commented Oct 25, 2018

Suggested merge commit message (convention)

Fix: Floated content and media widgets should not overlap. Closes ckeditor/ckeditor5#2769.


Additional information

I'm not sure whether this is a content style provided by a feature or a snippet style in our docs. I'd say the former but who knows ;-)

@oleq oleq requested a review from dkonopka October 25, 2018 10:24
@pomek
Copy link
Member

pomek commented Oct 25, 2018

Is it resolving the space between widgets (see the image below)

image

@oleq
Copy link
Member Author

oleq commented Oct 25, 2018

clear:both does not allow this kind of layout in the first place

image

Copy link
Contributor

@dkonopka dkonopka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM 👍

@dkonopka dkonopka merged commit d3aa6e8 into master Oct 26, 2018
@dkonopka dkonopka deleted the t/53 branch October 26, 2018 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media and side image could be styled better if they are next to themselves
3 participants