Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create index.d.ts file #333

Closed
wants to merge 1 commit into from
Closed

Create index.d.ts file #333

wants to merge 1 commit into from

Conversation

kolserdav
Copy link

  • Added file index.d.ts with basic types.
  • Added exception in .eslintrc.js (Parsing error: Missing initializer in const declaration.)
  • Added type paths to package.json

The types are not described in detail. Only in order to be able to comfortably start working with Typescript. More experienced developers of CKEditor5-React will be able to supplement them much better.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 449

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 447: 0.0%
Covered Lines: 183
Relevant Lines: 183

💛 - Coveralls

@kolserdav
Copy link
Author

I wrote types for myself. Decided to do a good deed at the same time. But, unfortunately, I have no time to process the license, if you can’t accept it, you can close this PR and just take my code and paste it yourself, if of course it interests you.

@pomek
Copy link
Member

pomek commented Nov 2, 2022

Hi @kolserdav,

Thanks for the amazing work you have done in the PR.

As you might notice, we are in the middle of rewriting the CKEditor 5 project to TypeScript. You can follow ckeditor/ckeditor5#11704 for more details.

Once it is done, we plan to provide typings for integrations with frameworks such as React, Vue, or Angular.

So far, I am not going to close the PR. Still, unfortunately, I cannot merge it as we will be rewriting the integrations to TypeScript, and typings will be provided automatically. I can't promise any ETA, though.

@kolserdav kolserdav closed this Nov 2, 2022
@kolserdav kolserdav deleted the create-types branch November 2, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants