Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/ckeditor5-media-embed/1: Aligned table tests to the latest engine dev utils #100

Closed
wants to merge 1 commit into from

Conversation

oleq
Copy link
Member

@oleq oleq commented Aug 20, 2018

Suggested merge commit message (convention)

Tests: Aligned table tests to the latest engine dev utilities which now print out the contents of the view UIElement (see ckeditor/ckeditor5#2727).


A piece of ckeditor/ckeditor5-media-embed#2 constellation.

…now also renders the content of the UIElements.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 251d6d1 on t/ckeditor5-media-embed/1 into 01f9a3b on master.

@Reinmar
Copy link
Member

Reinmar commented Aug 21, 2018

I'm against ckeditor/ckeditor5-engine#1506 so I'm R-ing this PR too because it won't be necessary.

@oleq
Copy link
Member Author

oleq commented Aug 22, 2018

This PR is no longer necessary as the utility to print the contents of the view became configurable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants