T/99: Introduce images in tables.

[jodator]

Suggested merge commit message (convention)

Feature: Introduce images in tables. Closes ckeditor/ckeditor5#3221.

---

Additional information

• Requires changes in
  • Widget: T/ckeditor5 table/99: Widget in editable should be clickable ckeditor5-widget#62 (will resolve Cannot click-select image in table ckeditor5#3219)
  • Engine: T/ckeditor5 table/99: Selection post-fixer improvements. ckeditor5-engine#1608
  • Image: Enable image in table cells. ckeditor5-image#262
  • BlockQuote: table/99: Update tests ckeditor5-block-quote#29
• Constelation of branches is available in CKEditor 5 branch.

[J-Nagle]

Thank you very much for this. We really needed this feature (and actually expected it to be there by default). This pull request is now in production on our system.

However, when using the third party Simple Image Upload plugin, the toolbar image upload button is still disabled inside table cells. It was necessary for us to use this instead of CKFinder as the documentation for uploading that way was not available on the CKEditor website at that time. Is it possible for you to look into this issue before moving on? If it's a problem on their side, we will probably migrate to CKFinder.

[jodator]

Is it possible for you to look into this issue before moving on

Oh. Thanks for the review!
I'll create a PR for this in the image feature and update the PR descriptions.

Here is the update image feature: ckeditor/ckeditor5-image#262.

[jodator]

[scofalik]

It looks like you forgot to mention that there is also a PR in block-quote :). I was writing a post that there are failing tests there :)

EDIT: I see there's no PR there, just the branch. Please create a PR. I've already looked there and there is just one line of code changed :).

[jodator]

It looks like you forgot to mention that there is also a PR in block-quote :). I was writing a post that there are failing tests there :)

Oh sorry. Fixing.

Edit: Fixed in PR description: ckeditor/ckeditor5-block-quote#29.

[dannybarinshtein]

This is exactly what i've been waiting for, thanks guys!

I am however running into an issue after migrating from the stable version of the table to the master in order to use this feature.

TypeError: i.for(...).elementToElement is not a function
    at zb.init (tableediting.js:91)

I am using the React Component - any ideas what could this be / if I missed a step?

Cheers

[J-Nagle]

@dannybarinshtein There was a significant refactor to CKEditor shortly following this change, found at ckeditor/ckeditor5-engine#1613. If you pull the master versions of all the repositories you’re using mentioned in that PR, you should be able to build a version of the project that no longer causes a TypeError.

We ran into this only yesterday and that’s how we fixed it. The developers also informed us that there might be breaking changes between the last version and the next release.

[dannybarinshtein]

@J-Nagle Thanks for the answer, its still not liking me for some reason.

I am trying to create the most basic form of the table at the moment, my package is as attached.

package.json.zip

But I am getting the following error:

TypeError: t is not iterable
at conversion.js:598
at Object.add (conversion.js:152)
at r_.init (tableediting.js:85)

Any thoughts or suggestions?