Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6106: Introduced color pickers in the table and table cell property forms #244

Merged
merged 41 commits into from
Feb 13, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented Feb 12, 2020

Suggested merge commit message (convention)

Feature: Introduced color pickers in the table and table cell property forms. Introduced config.table.tableProperties and config.table.tableCellProperties configurations. Closes ckeditor/ckeditor5/issues/6106.


Additional information

Requires:

Some follow-ups

image

@oleq oleq requested a review from jodator February 12, 2020 13:10
@jodator
Copy link
Contributor

jodator commented Feb 12, 2020

Follow-ups:

Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes are required:

  1. If you think that we should go with table.borderColors instead of table.border.colors (without waiting for @Reinmar) then we're on the same page here as I'm for borderColors :)
  2. The tests file for new class requires some cleanup.

For me this can be closed after the changes are applied.

src/tablecellproperties.js Outdated Show resolved Hide resolved
src/tablecellproperties/ui/tablecellpropertiesview.js Outdated Show resolved Hide resolved
src/tableproperties.js Outdated Show resolved Hide resolved
src/ui/utils.js Outdated Show resolved Hide resolved
tests/manual/tableproperties.js Outdated Show resolved Hide resolved
tests/manual/tableproperties.js Outdated Show resolved Hide resolved
tests/ui/colorinputview.js Show resolved Hide resolved
tests/ui/colorinputview.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 12, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 3bb62eb on i/6106 into b0c0591 on master.

@Reinmar
Copy link
Member

Reinmar commented Feb 12, 2020

One more followup ckeditor/ckeditor5#6241.

@Reinmar
Copy link
Member

Reinmar commented Feb 13, 2020

cc @ckeditor/qa-team

@Mgsy
Copy link
Member

Mgsy commented Feb 13, 2020

Looks good 👍

@Reinmar Reinmar merged commit c4ccd1e into master Feb 13, 2020
@Reinmar Reinmar deleted the i/6106 branch February 13, 2020 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table properties UI] Implement a rich color picker for table (and table cell) properties
6 participants