This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
I/6106: Introduced color pickers in the table and table cell property forms #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2020
Merged
Follow-ups:
|
jodator
suggested changes
Feb 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes are required:
- If you think that we should go with
table.borderColors
instead oftable.border.colors
(without waiting for @Reinmar) then we're on the same page here as I'm forborderColors
:) - The tests file for new class requires some cleanup.
For me this can be closed after the changes are applied.
Co-Authored-By: Maciej <jodator@jodator.net>
Reinmar
reviewed
Feb 12, 2020
One more followup ckeditor/ckeditor5#6241. |
cc @ckeditor/qa-team |
…igurations (borders and background colors).
Looks good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced color pickers in the table and table cell property forms. Introduced
config.table.tableProperties
andconfig.table.tableCellProperties
configurations. Closes ckeditor/ckeditor5/issues/6106.Additional information
Requires:
normalizeColorOptions()
andgetLocalizedColorOptions()
ckeditor5-ui#541 (added color grid utils that are now common for ckeditor5-table and ckeditor5-font)normalizeColorOptions()
andgetLocalizedColorOptions()
ckeditor5-font#59 (moved color grid utils to ckeditor5-ui)Some follow-ups