Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

i/5782: Implemented styles for .ck-button with a keystroke preview. #252

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Nov 22, 2019

Suggested merge commit message (convention)

Feature: Implemented styles for .ck-button with a keystroke preview (see ckeditor/ckeditor5#5782).


Additional information

Part of ckeditor/ckeditor5-ui#531.

@Reinmar
Copy link
Member

Reinmar commented Nov 25, 2019

The difference in styling between the label and the keystroke is IMO a bit too small, but I checked that the keystroke has the lowest possible contrast already, so there's not much room for improvement (by changing the color). Let's see how it will look in a real feature.

image

@Reinmar Reinmar merged commit 8427306 into master Nov 25, 2019
@Reinmar Reinmar deleted the i/5782 branch November 25, 2019 11:25
@oleq
Copy link
Member Author

oleq commented Nov 27, 2019

What you posted is not a real use-case because this kind of information will be used in drop–down menus only (does not make much sense in toolbars). And in that situation, there's some gap between the label and the keystroke, and some specific alignment, etc..

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants