This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Bogus
<br />
element inserted by a browser at the end of an element is now correctly handled. Closes ckeditor/ckeditor5#1083.Additional information
This is not a complete solution. I don't like two things:
@
in place of non-text elements. I tested it manually and it looks like everything works well but I am a little skeptical because a user may type@
by themselves and I am afraid it may mess up the diff. Still, I tried putting<br />
between typed@
s and it worked 🤷♂️ .<softBreak>
"inline" element is now supported. I wanted to do it in a future-proof way but I don't know how you can differentiate that given elements are "inline" elements (like<softBreak>
). Basically, when we will introduce a new inline element, like smileys or maybe placeholders, we again will have a problem inisSafeForTextMutation
function. Maybe we could introduceisInline
flag inSchemaItemDefinition
?