Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for promise (async) errors #4694

Closed
ma2ciek opened this issue Jun 25, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-watchdog#20
Closed

Add support for promise (async) errors #4694

ma2ciek opened this issue Jun 25, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-watchdog#20
Assignees
@ma2ciek
Labels
package:watchdog type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 26

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Jun 25, 2019

Errors that will be thrown inside the async functions won't be handled correctly by the current implementation of the watchdog (#1). The onunhandledrejection should be taken into consideration.
@ma2ciek
Copy link
Contributor Author

ma2ciek commented Aug 7, 2019

This feature should be easy to implement and it will improve error handling in collaboration features a lot.

@ma2ciek ma2ciek self-assigned this Aug 7, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-watchdog Aug 8, 2019
Merge pull request #20 from ckeditor/t/3
1a47364 
Feature: Added unhandled promise rejection error handling. Fixed objects in the `crashed` array. Closes #3.
pjasiun referenced this issue in ckeditor/ckeditor5-dev Aug 8, 2019
Merge pull request #539 from ckeditor/t/ckeditor5-watchdog/3
799b272 
Other: Added `ErrorEvent` and `PromiseRejectionEvent` types to the JSDoc validator. Part of ckeditor/ckeditor5-watchdog#3.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-watchdog Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:watchdog labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:watchdog type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Add unhandled promise rejection error handling ckeditor/ckeditor5-watchdog
2 participants
@ma2ciek @mlewand