This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add unhandled promise rejection error handling #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that the red test is from Firefox, which will support the Compatibility table: https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onunhandledrejection. |
|
Maybe, for now, we can write a test for Chrome only? cc @pjasiun. |
Yep. I was also thinking about it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added unhandled promise rejection error handling. Fixed objects in the
crashedarray Closes ckeditor/ckeditor5#4694.Additional information
From now all unhandled promise rejections will be caught by the watchdog, and if such error comes from the watchdog's editor the watchdog will restart it.
For example – encountered issues, assumptions you had to make, other affected tickets, etc.
Requires ckeditor/ckeditor5-dev#539.