Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Handling ctrl+a when widget is selected. #24

Merged
merged 4 commits into from
Oct 23, 2017
Merged

Handling ctrl+a when widget is selected. #24

merged 4 commits into from
Oct 23, 2017

Conversation

szymonkups
Copy link
Contributor

@szymonkups szymonkups commented Oct 19, 2017

Suggested merge commit message (convention)

Fix: Correctly handling select all keystroke when widget is selected. Closes ckeditor/ckeditor5#4583.

@szymonkups szymonkups requested review from Reinmar and Mgsy October 19, 2017 09:56
Copy link
Member

@Mgsy Mgsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works good 👌

theme/theme.scss Outdated
@@ -17,6 +17,7 @@ $widget-outline-thickness: 3px;
.ck-widget {
margin: ck-spacing() 0;
padding: 0;
//user-select: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - I will remove it.

@oskarwrobel oskarwrobel merged commit 3e8f91f into master Oct 23, 2017
@oskarwrobel oskarwrobel deleted the t/23 branch October 23, 2017 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTRL+A on widgets moves the caret to the beginning of the editor
3 participants