Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/ckeditor5/1151: Added a manual test for widget selection handler in different UI language directions #96

Merged
merged 2 commits into from
Aug 12, 2019
Merged

t/ckeditor5/1151: Added a manual test for widget selection handler in different UI language directions #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a718616
Tests: Added a manual test for widget selection handler in different …
oleq Jul 25, 2019
39a2fae
Test: Updated selection handler manual test description.
oleq Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions tests/manual/selection-handler.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<head>
<style>
body {
max-width: 800px;
margin: 20px auto;
}

.ck-content .widget {
background: rgba( 0, 0, 0, 0.1 );
min-height: 50px;
}
</style>
</head>

<h2>LTR UI</h2>

<div id="editor-ltr">
<h2>Heading 1</h2>
<p>Paragraph</p>
<div class="widget"></div>
<p>Paragraph</p>
</div>

<h2>RTL UI</h2>

<div id="editor-rtl">
<h2>Heading 1</h2>
<p>Paragraph</p>
<div class="widget"></div>
<p>Paragraph</p>
</div>
82 changes: 82 additions & 0 deletions tests/manual/selection-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
/**
* @license Copyright (c) 2003-2019, CKSource - Frederico Knabben. All rights reserved.
* For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
*/

/* globals console, window, document */

import Widget from '../../src/widget';
import { toWidget } from '../../src/utils';
import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset';

function MyPlugin( editor ) {
editor.model.schema.register( 'div', {
allowIn: [ '$root' ],
isObject: true
} );

editor.conversion.for( 'downcast' ).elementToElement( {
model: 'div',
view: ( modelElement, writer ) => {
return toWidget( writer.createContainerElement( 'div', {
class: 'widget'
} ),
writer,
{ hasSelectionHandler: true } );
}
} );

editor.conversion.for( 'upcast' ).elementToElement( {
model: 'div',
view: 'div'
} );
}

const config = {
plugins: [ ArticlePluginSet, Widget, MyPlugin ],
toolbar: [
'heading',
'|',
'bold',
'italic',
'link',
'bulletedList',
'numberedList',
'blockQuote',
'insertTable',
'mediaEmbed',
'undo',
'redo'
],
image: {
toolbar: [ 'imageStyle:full', 'imageStyle:side', '|', 'imageTextAlternative' ]
},
table: {
contentToolbar: [
'tableColumn',
'tableRow',
'mergeTableCells'
]
}
};

ClassicEditor
.create( document.querySelector( '#editor-ltr' ), config )
.then( editor => {
window.editorLtr = editor;
} )
.catch( err => {
console.error( err.stack );
} );

ClassicEditor
.create( document.querySelector( '#editor-rtl' ), Object.assign( {}, config, {
language: 'ar'
} ) )
.then( editor => {
window.editorRtl = editor;
} )
.catch( err => {
console.error( err.stack );
} );
17 changes: 17 additions & 0 deletions tests/manual/selection-handler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Widget selection handler

**Note**: For the best testing, run manual tests adding Arabic to [additional languages configuration](https://ckeditor.com/docs/ckeditor5/latest/framework/guides/contributing/testing-environment.html#running-manual-tests).

---

1. Focus the widget.
1. The outline of the widget and the selection handler should be continuous.
1. The selection handler should be attached to the top of the widget.

## LTR

1. The selection handler should be displayed on the **left** side of the widget.

## RTL

1. The selection handler should be displayed on the **right** side of the widget.