Merge pull request #17345 from ckeditor/fix-treeshaking-of-icons

Fix (bookmarks): Avoid global state to improve icons tree-shaking.
ckeditor · Oct 28, 2024 · 49edd01 · 49edd01
2 parents d975572 + c59c9c2
commit 49edd01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packages/ckeditor5-bookmark/src/bookmarkediting.ts b/packages/ckeditor5-bookmark/src/bookmarkediting.ts
@@ -28,8 +28,6 @@ import UpdateBookmarkCommand from './updatebookmarkcommand.js';
 
 import '../theme/bookmark.css';
 
-const bookmarkIcon = icons.bookmarkInline;
-
 /**
  * The bookmark editing plugin.
  */
@@ -162,7 +160,7 @@ export default class BookmarkEditing extends Plugin {
 			const icon = new IconView();
 
 			icon.set( {
-				content: bookmarkIcon,
+				content: icons.bookmarkInline,
 				isColorInherited: false
 			} );
 

diff --git a/packages/ckeditor5-bookmark/src/bookmarkui.ts b/packages/ckeditor5-bookmark/src/bookmarkui.ts
@@ -34,8 +34,6 @@ import type InsertBookmarkCommand from './insertbookmarkcommand.js';
 
 import BookmarkEditing from './bookmarkediting.js';
 
-const bookmarkIcon = icons.bookmark;
-
 const VISUAL_SELECTION_MARKER_NAME = 'bookmark-ui';
 
 /**
@@ -275,7 +273,7 @@ export default class BookmarkUI extends Plugin {
 
 		view.set( {
 			label: t( 'Bookmark' ),
-			icon: bookmarkIcon
+			icon: icons.bookmark
 		} );
 
 		// Execute the command.