Merge pull request #12990 from ckeditor/ck/12939-fix-find-and-replace…

…-in-source-editing-mode Fix (find-and-replace): Disable the find and replace popup in source mode. Closes #12939.
ckeditor · Dec 8, 2022 · d7885a5 · d7885a5
2 parents 30acb8f + f274db8
commit d7885a5
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/packages/ckeditor5-find-and-replace/src/findandreplaceui.js b/packages/ckeditor5-find-and-replace/src/findandreplaceui.js
@@ -104,8 +104,10 @@ export default class FindAndReplaceUI extends Plugin {
  } );
 
  editor.keystrokes.set( 'Ctrl+F', ( data, cancelEvent ) => {
- dropdown.isOpen = true;
- cancelEvent();
+ if ( dropdown.isEnabled ) {
+ dropdown.isOpen = true;
+ cancelEvent();
+ }
  } );
  }
 

diff --git a/packages/ckeditor5-find-and-replace/tests/findandreplaceui.js b/packages/ckeditor5-find-and-replace/tests/findandreplaceui.js
@@ -156,6 +156,28 @@ describe( 'FindAndReplaceUI', () => {
  expect( dropdown.buttonView.keystroke ).to.equal( 'CTRL+F' );
  } );
 
+ it( 'should not open the dropdown when command is disabled and CTRL+F was pressed', () => {
+ findCommand.isEnabled = false;
+
+ expect( dropdown.isOpen ).to.be.false;
+ expect( dropdown.isEnabled ).to.be.false;
+
+ const keyEventData = ( {
+ keyCode: keyCodes.f,
+ ctrlKey: !env.isMac,
+ metaKey: env.isMac,
+ preventDefault: sinon.spy(),
+ stopPropagation: sinon.spy()
+ } );
+
+ const wasHandled = editor.keystrokes.press( keyEventData );
+
+ expect( wasHandled ).to.be.true;
+ expect( keyEventData.preventDefault.notCalled ).to.be.true;
+
+ expect( dropdown.isOpen ).to.be.false;
+ } );
+
  it( 'should open the dropdown when CTRL+F was pressed', () => {
  const spy = sinon.spy( form._findInputView.fieldView, 'select' );