Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The find and replace does not support ctrl/cmd+g to go to next match (and reversed with shift) #10012

Closed
niegowski opened this issue Jun 30, 2021 · 4 comments · Fixed by #10409
Closed

The find and replace does not support ctrl/cmd+g to go to next match (and reversed with shift) #10012

niegowski opened this issue Jun 30, 2021 · 4 comments · Fixed by #10409
Assignees
@arkflpc
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 46 (v29...

Comments

@niegowski
Copy link
Contributor

📝 Provide a description of the improvement

http://fake.ckeditor.com:8081/build/docs/ckeditor5/latest/features/find-and-replace.html

the find and replace supports ctrl/cmd+f keystroke but it does not support ctrl/cmd+g and shift+ctrl/cmd+g

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@niegowski niegowski added type:improvement This issue reports a possible enhancement of an existing feature. squad:features Issue to be handled by the Features team. package:find-and-replace labels Jun 30, 2021
@niegowski
Copy link
Contributor Author

Also, enter key should move to the next result while search input was not changed but enter was pressed.

@niegowski
Copy link
Contributor Author

Maybe the focus should be moved to the "find next" button on the enter key press?

@oleq
Copy link
Member

oleq commented Jul 28, 2021

Let's figure out the enter key support in this issue.

@oleq oleq added domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. and removed squad:features Issue to be handled by the Features team. labels Jul 28, 2021
@oleq oleq added this to the iteration 46 milestone Jul 28, 2021
@oleq oleq added the squad:core Issue to be handled by the Core team. label Jul 28, 2021
@Reinmar Reinmar modified the milestones: iteration 46, nice-to-have Aug 4, 2021
@Reinmar
Copy link
Member

Reinmar commented Aug 4, 2021

We should listen on Enter / Shift+Enter (TODO @oleq???) when the focus is on the search input

@Reinmar Reinmar modified the milestones: nice-to-have, iteration 46 Aug 16, 2021
@arkflpc arkflpc mentioned this issue Aug 24, 2021
Merged
oleq added a commit that referenced this issue Aug 24, 2021
@oleq
Merge pull request #10409 from ckeditor/ck/10012-hit-enter-to-find-next
fe554b9 
Feature (find-and-replace): Made it possible to cycle find results by using <kbd>Enter</kbd> and <kbd>Shift</kbd>+<kbd>Enter</kbd> keystrokes. Closes #10012.
@Reinmar Reinmar mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 46 (v29.2.0)
Development

Successfully merging a pull request may close this issue.

Hit Enter to find next and Shift+Enter to find previous ckeditor/ckeditor5
4 participants
@Reinmar @oleq @niegowski @arkflpc