Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"translations:collect" does not return the proper exit code in case of an error #10123

Closed
pomek opened this issue Jul 12, 2021 · 0 comments · Fixed by ckeditor/ckeditor5-dev#715
Closed

"translations:collect" does not return the proper exit code in case of an error #10123

pomek opened this issue Jul 12, 2021 · 0 comments · Fixed by ckeditor/ckeditor5-dev#715
Assignees
@pomek
Labels
package:dev squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 45 (v29...

Comments

@pomek
Copy link
Member

pomek commented Jul 12, 2021

📝 Provide detailed reproduction steps (if any)

  1. Create an unused translation context
  2. Execute yarn run translations:collect

✔️ Expected result

The proper exit code is returned when an error has been found.

❌ Actual result

The process does not fail so it can't be executed on CI because the build will not fail.
@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:devops Issue to be handled by the Devops team. package:dev labels Jul 12, 2021
@pomek pomek added this to the iteration 45 milestone Jul 12, 2021
@pomek pomek self-assigned this Jul 12, 2021
@pomek pomek mentioned this issue Jul 12, 2021
Merged
mlewand added a commit to ckeditor/ckeditor5-dev that referenced this issue Jul 12, 2021
@mlewand
Merge pull request #715 from ckeditor/ck/10123
36d1190 
Other (env): Set the proper exit code when found an error when collecting translations. Closes ckeditor/ckeditor5#10123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:dev squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 45 (v29.1.0)
Development

Successfully merging a pull request may close this issue.

Exit code when translations:collect reports an error ckeditor/ckeditor5-dev
1 participant
@pomek