Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Whole words only" checkbox does not work correctly when searching for query with 'space' #10131

Closed
mateuszzagorski opened this issue Jul 12, 2021 · 0 comments · Fixed by #10390
Closed

"Whole words only" checkbox does not work correctly when searching for query with 'space' #10131

mateuszzagorski opened this issue Jul 12, 2021 · 0 comments · Fixed by #10390
Assignees
@arkflpc
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 46 (v29...

Comments

@mateuszzagorski
Copy link
Contributor

mateuszzagorski commented Jul 12, 2021 •
edited by Reinmar
Loading

📝 Provide detailed reproduction steps (if any)

  1. Go to the documentation page.
  2. Search for, for example: rather in foo rather bar
  3. Check the "Whole words only" checkbox, and search again.

✔️ Expected result

One result remains highlighted.

NOTE: It's a valid use case to search for a term with a trailing space.

❌ Actual result

No results were shown.

📃 Other details

  • Browser: Chrome
  • OS: macOS BigSur 11.3
  • The same behavior can be replicated in manual tests.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@mateuszzagorski mateuszzagorski added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace labels Jul 12, 2021
@mateuszzagorski mateuszzagorski changed the title "Whole words only" checkbox does not work correctly when searching for query with 'space'. "Whole words only" checkbox does not work correctly when searching for query with 'space' Jul 12, 2021
@oleq oleq added the squad:core Issue to be handled by the Core team. label Jul 28, 2021
@oleq oleq added this to the iteration 46 milestone Jul 28, 2021
@Reinmar Reinmar modified the milestones: iteration 46, nice-to-have Aug 4, 2021
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 46 Aug 16, 2021
@arkflpc arkflpc mentioned this issue Aug 20, 2021
Merged
niegowski added a commit that referenced this issue Aug 23, 2021
@niegowski
Merge pull request #10390 from ckeditor/ck/10131-whole-search-with-sp…
fd9dfa7 
…aces

Fix (find-and-replace): Allows search term to contain trailing/leading space when searching "whole words only". Closes #10131.
@Reinmar Reinmar mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 46 (v29.2.0)
Development

Successfully merging a pull request may close this issue.

Ck/10131 Whole word search with spaces ckeditor/ckeditor5
4 participants
@Reinmar @oleq @arkflpc @mateuszzagorski