-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add the "accessibility instructions" modal #1014
Comments
Thanks for the report. Indeed, CKEditor 4 has such a modal: We may need a similar one for CKEditor 5. I wonder, though, how many apps handle Alt+0? I checked a couple of places (GH, Slack, Google Docs) and none of them showed anything. Does that mean that they don't implement some important accessibility feature? Or is such a modal something specific for CKEditor 4? |
Both Gmail and GitHub implement this feature, but it's under ⇧ Shift+/ (or simply ?) which only makes sense when there's no focus in the text input field, which, again, does not make any sense in a text editor ;-) Also kepp in mind that, as complete ecosystems, these applications have more freedom when it comes to selecting keystrokes. That's most likely why we used Alt+0 in v4. P.S. In Slack it is under ⌘+/. |
There are many variations, but most commonly apps use As @oleq mentioned there are apps using IMO the best option for us is |
It'd be also good to make it discoverable also for non-screen-reader users, especially:
|
Regarding the shortcut for the modal help dialog:
|
+1 to the feature request. |
Feature (ui): Implemented the `AccessibilityHelp` plugin that brings a dialog displaying keyboard shortcuts available in the editor. Closes #1014. Feature (core): Brought the `editor.accessibility` namespace to the base `Editor` class as a container for accessibility-related features and systems. See #1014. Other (essentials): Enabled the `AccessibilityHelp` plugin by default. See #1014. Fix (utils): The exported `keyCodes` object should contain correct codes for keys related to punctuation, brackets, braces, etc. See #1014.
Is this a bug report or feature request? (choose one)
🆕 Feature request
💻 Version of CKEditor
CKEditor 5 builds
📋 Steps to reproduce
✅ Expected result
Accessibility instructions modal pops up
❎ Actual result
I get a degrees symbol on my Mac inserted in the text area 😅
If you'd like to see this feature implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: