Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find & replace: Match case and whole words do not work after recent merges #10188

Closed
LukaszGudel opened this issue Jul 20, 2021 · 1 comment
Closed

Find & replace: Match case and whole words do not work after recent merges #10188

LukaszGudel opened this issue Jul 20, 2021 · 1 comment
Labels
package:find-and-replace resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@LukaszGudel
Copy link
Contributor

LukaszGudel commented Jul 20, 2021 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Open editor with F&R plugin with ckeditor5 repo on branch ck/10023
  2. Search a character a with "Whole words only" flag.

✔️ Expected result

Only single words a will be highlighted.

❌ Actual result

Every a character is highlighted, while UI is not showing any results and there are no arrow buttons to go through the results.
image

📃 Other details

The same result will be produced when searching for A with "Match case" flag.

This regression on branch ck/10023 was introduced after merging origin/ck/10024-find-and-replace-followups into ck/10023 with commit 5c2b2db. Before this commit, these search flags are working correctly.
@LukaszGudel LukaszGudel added type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases. squad:features Issue to be handled by the Features team. package:find-and-replace labels Jul 20, 2021
mlewand added a commit that referenced this issue Jul 20, 2021
@mlewand
Internal (find-and-replace): Fixed a regression that caused search fl…
464fc20 
…ags not to be passed over. Closes #10188.

Marked as internal as this bug was just introduced in this iteration and hadn't made into a public release.
@oleq oleq added this to the iteration 46 milestone Jul 28, 2021
@oleq oleq added squad:core Issue to be handled by the Core team. and removed squad:features Issue to be handled by the Features team. labels Jul 28, 2021
@Reinmar Reinmar modified the milestones: iteration 46, nice-to-have Aug 4, 2021
@Reinmar
Copy link
Member

Reinmar commented Aug 4, 2021

We dropped ck/10023 during the feature handoff. I'm closing this ticket as it's not reproducible on master.

@Reinmar Reinmar closed this as completed Aug 4, 2021
@Reinmar Reinmar removed this from the nice-to-have milestone Aug 4, 2021
@Reinmar Reinmar added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Aug 19, 2021
@Reinmar Reinmar mentioned this issue Sep 6, 2021
Closed
@Witoso Witoso mentioned this issue Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:find-and-replace resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Reinmar @oleq @LukaszGudel