Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML comment: comments' content is lost but comments' markers still exist #10274

Closed
psmyrek opened this issue Jul 30, 2021 · 0 comments · Fixed by #10286
Closed

HTML comment: comments' content is lost but comments' markers still exist #10274

psmyrek opened this issue Jul 30, 2021 · 0 comments · Fixed by #10286
Assignees
@psmyrek
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 46 (v29...

Comments

@psmyrek
Copy link
Contributor

psmyrek commented Jul 30, 2021 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Open HTML comment manual test: http://localhost:8125/ckeditor5-html-support/tests/manual/htmlcomment.html.
  2. Select the nested list and paste it in the list item.

✔️ Expected result

$root attributes should be kept.

❌ Actual result

$root attributes are removed, so all the existing comments' content become undefined.

root.attributes.for.html.comments.are.removed.mp4

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@psmyrek psmyrek added type:bug This issue reports a buggy (incorrect) behavior. squad:compat domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support labels Jul 30, 2021
@psmyrek psmyrek changed the title HTML comment: $root attributes are removed if list is pasted in the list item HTML comment: comments' content is lost but comments' markers still exist Jul 30, 2021
@ma2ciek ma2ciek added the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Jul 30, 2021
@mlewand mlewand removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Jul 30, 2021
@mlewand mlewand added this to the iteration 46 milestone Jul 30, 2021
@ma2ciek ma2ciek mentioned this issue Jul 30, 2021
Closed
@psmyrek psmyrek mentioned this issue Aug 2, 2021
Merged
@psmyrek psmyrek self-assigned this Aug 2, 2021
maxbarnas added a commit that referenced this issue Aug 2, 2021
@maxbarnas
Merge pull request #10286 from ckeditor/ck/10274
35b08a9 
Fix (html-support): Extended schema definition for $root to allow storing comment's content as the $root attribute. Closes #10274.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:html-support type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 46 (v29.2.0)
Development

Successfully merging a pull request may close this issue.

Allow storing comment's content as the $root attribute ckeditor/ckeditor5
3 participants
@ma2ciek @mlewand @psmyrek