Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the search text should reset the results #10304

Closed
Reinmar opened this issue Aug 4, 2021 · 0 comments · Fixed by #10344
Closed

Changing the search text should reset the results #10304

Reinmar opened this issue Aug 4, 2021 · 0 comments · Fixed by #10344
Assignees
@oleq
Labels
package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 46 (v29...

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 4, 2021

📝 Provide detailed reproduction steps (if any)

  1. Type "Steam"
  2. Click "Find"
  3. Press backspace

✔️ Expected result

Highlights are removed. The state of the form gets back to its initial state.

❌ Actual result

The results for "Steam" are still displayed.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. package:find-and-replace labels Aug 4, 2021
@Reinmar Reinmar modified the milestones: backlog, iteration 46 Aug 4, 2021
@Reinmar Reinmar removed this from the iteration 46 milestone Aug 16, 2021
@Reinmar Reinmar mentioned this issue Aug 16, 2021
Merged
@Reinmar Reinmar added this to the iteration 46 milestone Aug 16, 2021
@oleq oleq self-assigned this Aug 23, 2021
maxbarnas added a commit that referenced this issue Aug 23, 2021
@maxbarnas
Merge pull request #10344 from ckeditor/ck/10229-find-and-replace-revamp
dc31609 
Other (find-and-replace): Visually revamped the find&replace form. Closes #10229.

Fix (find-and-replace): Changing the search text should reset the results. Closes #10304.

Fix (find-and-replace): Toggling search options should reset the results. Closes #10021.

Fix (find-and-replace): The find and replace form should be responsive. Closes #10019.

Internal (find-and-replace): Fixed the styling issue that was triggering style linter. Removed linter's ignore clause. Closes #9928.

Feature (core): Added the "cog" icon to the core icon set (see #10229).

Other (theme-lark): Moved presentational find and replace form styles to the theme (see #10229).

Fix (theme-lark): The label of the labeled field should stay on the top when the field is disabled and not empty to not cover the field's text (see #10229).

BREAKING CHANGE (find-and-replace): The layout, styling, and view structure of the find and replace form have changed radically, which may affect integrations that either customized or extended this form (see #10229).
@Reinmar Reinmar mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 46 (v29.2.0)
Development

Successfully merging a pull request may close this issue.

Revamped the find&replace UI. ckeditor/ckeditor5
2 participants
@Reinmar @oleq