Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid cell property after pasting a table to the editor from Word #10383

Closed
Mgsy opened this issue Aug 20, 2021 · 5 comments · Fixed by #10495
Closed

Invalid cell property after pasting a table to the editor from Word #10383

Mgsy opened this issue Aug 20, 2021 · 5 comments · Fixed by #10495
Assignees
Labels
package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mgsy
Copy link
Member

Mgsy commented Aug 20, 2021

📝 Provide detailed reproduction steps (if any)

  1. Open the sample Word document from our documentation.
  2. Select the table and copy it.
  3. Paste the table to the editor, e.g. in the Paste from Word demo.
  4. Put the caret in the first cell.
  5. Open the table cell properties window.

✔️ Expected result

It displays correct values.

❌ Actual result

The border color field has windowtext value and is highlighted as invalid.

📃 Other details

It's not a regression.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. package:paste-from-office squad:core Issue to be handled by the Core team. labels Aug 20, 2021
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Aug 20, 2021
@Reinmar
Copy link
Member

Reinmar commented Aug 25, 2021

CKE4: ckeditor/ckeditor4#2923

@Reinmar
Copy link
Member

Reinmar commented Aug 25, 2021

@Reinmar Reinmar added this to the iteration 47 milestone Aug 30, 2021
@arkflpc arkflpc self-assigned this Sep 7, 2021
@arkflpc
Copy link
Contributor

arkflpc commented Sep 8, 2021

Shall we add all depreciated system colors from the spec?

@Reinmar
Copy link
Member

Reinmar commented Sep 8, 2021

Yes, I see no point in adding just one color. These are valid color values. They are deprecated (so we wouldn't use them), but we can accept them as values.

@Reinmar
Copy link
Member

Reinmar commented Sep 8, 2021

However, just to be sure: do you see a problem with adding all the colors?

niegowski added a commit that referenced this issue Sep 10, 2021
Fix (engine): Adds System Colors names from CSS Color Module Level 3 so that pasting tables from MS Word works correctly. Closes #10383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants