Incorrect marker conversion (highlights) on some view elements #10425
Assignees
Labels
package:engine
package:image
package:table
type:bug
This issue reports a buggy (incorrect) behavior.
Milestone
Comments
scofalik
added
type:bug
scofalik
added a commit
that referenced
this issue
Sep 7, 2021
Fix (table, image): Attributes from a marker conversion descriptor will be correctly added on view elements during marker downcast. Closes #10425. Other (widget): `toWidgetEditable()` will now set the default highlight handling for the editable element. Other (widget): `setHighlightHandling()` received default parameters for highlight add and remove functions which handles classes and attributes. MINOR BREAKING CHANGE: `toWidgetEditable()` will now set highlight handling for the editable element. If you used this method in conversion in your custom plugin, it may affect your element styling when there is a marker on that element (e.g. a comment or a suggestion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📝 Provide detailed reproduction steps (if any)
Image captions and table cells do not receive attributes when marker on them is converted. It turns out that features providing those view elements use
setHighlightHandling()but those features have outdatedaddHighlightandremoveHighlightfunctions. We already fixed (improved) those methods for the default widget utiltoWidget(). However, since those features do not usetoWidget()they have incorrect highlighting.The text was updated successfully, but these errors were encountered: