Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release:publish should not print an error if a package does not exist on npm and it will not be published #10639

Closed
pomek opened this issue Oct 4, 2021 · 0 comments · Fixed by ckeditor/ckeditor5-dev#730
Assignees
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Oct 4, 2021

📝 Provide detailed reproduction steps (if any)

It's hard to reproduce because you need to find a package that will not be published on npm but it's tracked in the repository.

It happened when I was releasing changes from https://github.com/ckeditor/ckeditor5-package-generator.

✔️ Expected result

Checking "@ckeditor/ckeditor5-package-generator"...

⚠️  Skipping because the package was listed as `options.skipNpmPublish`.

❌ Actual result

Checking "@ckeditor/ckeditor5-package-generator"...
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@ckeditor%2fckeditor5-package-generator - Not found
npm ERR! 404
npm ERR! 404  '@ckeditor/ckeditor5-package-generator@latest' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/pomek/.npm/_logs/2021-10-04T09_53_14_521Z-debug.log

⚠️  Skipping because the package was listed as `options.skipNpmPublish`.

❓ Possible solution

@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. package:dev labels Oct 4, 2021
@pomek pomek added this to the iteration 48 milestone Oct 11, 2021
@pomek pomek self-assigned this Oct 19, 2021
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Oct 20, 2021
Fix (env): The `releaseSubRepositories()` task does not check the npm version if a package will not be published anyway. Closes ckeditor/ckeditor5#10639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant