Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watchdog's _save method can be called when the editor is being destroyed #10643

Closed
ma2ciek opened this issue Oct 4, 2021 · 0 comments · Fixed by #10962
Closed

Watchdog's _save method can be called when the editor is being destroyed #10643

ma2ciek opened this issue Oct 4, 2021 · 0 comments · Fixed by #10962
Assignees
@ma2ciek
Labels
package:watchdog squad:collaboration Issue to be handled by the Collaboration team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 50 (v32...

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Oct 4, 2021 •
edited
Loading

https://github.com/ckeditor/ckeditor5-watchdog/blob/64495826718bf7e9ee414a299680775f7df4a6ea/src/editorwatchdog.js#L248

It seems that this issue is connected with the fact that selecting or deselecting a comment currently fires a change:data event (#9901).

I suspect that stopping the change:data listener just before destroying the editor should be enough to solve this issue:

https://github.com/ckeditor/ckeditor5-watchdog/blob/64495826718bf7e9ee414a299680775f7df4a6ea/src/editorwatchdog.js#L226-L240
@ma2ciek ma2ciek added type:bug This issue reports a buggy (incorrect) behavior. support:2 An issue reported by a commercially licensed client. package:watchdog squad:collaboration Issue to be handled by the Collaboration team. labels Oct 4, 2021
@ma2ciek ma2ciek mentioned this issue Oct 4, 2021
Closed
@ma2ciek ma2ciek mentioned this issue Dec 6, 2021
Merged
scofalik added a commit that referenced this issue Dec 6, 2021
@scofalik
Merge pull request #10962 from ckeditor/cke/10643
9151ef7 
Fix (watchdog): Prevented `EditorWatchdog` from crashing during the editor destruction process when one of plugins tries to change data at that moment. Closes #10643.
@scofalik scofalik added this to the iteration 50 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:watchdog squad:collaboration Issue to be handled by the Collaboration team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 50 (v32.0.0)
2 participants
@scofalik @ma2ciek