Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing environment - upgrade Karma to the latest version #11337

Closed
pomek opened this issue Feb 24, 2022 · 4 comments · Fixed by ckeditor/ckeditor5-dev#763
Closed

Testing environment - upgrade Karma to the latest version #11337

pomek opened this issue Feb 24, 2022 · 4 comments · Fixed by ckeditor/ckeditor5-dev#763
Assignees
@psmyrek
Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 52 (v34...

Comments

@pomek
Copy link
Member

pomek commented Feb 24, 2022

📝 Provide a description of the new task

As in the title, due to:

(node:60317) [log4js-node-DEP0004] DeprecationWarning: Pattern %d{DATE} is deprecated due to the confusion it causes when used. Please use %d{DATETIME} instead.

Unfortunately, Karma@6 introduced a few breaking changes that touch our env.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. labels Feb 24, 2022
@pomek pomek added squad:platform Issue to be handled by the Platform team. and removed squad:platform Issue to be handled by the Platform team. labels Mar 14, 2022
@pomek pomek mentioned this issue Mar 15, 2022
Closed
@pomek
Copy link
Member Author

pomek commented Mar 16, 2022

After upgrading to Karma 6, the following warning is reported:

16 03 2022 12:15:34.369:WARN [karma-server]: Passing raw CLI options to `new Server(config, done)` is deprecated. Use `parseConfig(configFilePath, cliOptions, {promiseConfig: true, throwErrors: true})` to prepare a processed `Config` instance and pass that as the `config` argument instead.

@pomek
Copy link
Member Author

pomek commented Mar 16, 2022

Scope

  • Upgrade karma from 5 to 6
  • When executing tests, it prints the deprecated warning.
  • Rewrite a part of the code to drop the "deprecated warning".
  • Make sure all supported options still work (see the testing env. guide).
  • The intellijkarmarunner plugin must work.
  • Perhaps it's a good occasion to refactor the runautomatedtests.js file (e.g. a function should not be defined as a string).

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Mar 16, 2022
@pomek
Copy link
Member Author

pomek commented Mar 16, 2022

TODO: Report a follow-up issue for upgrading karma in the following repositories:

  • Package generator
  • Inspector
  • Integrations (2x Vue, React, perhaps Angular too).

@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 16, 2022
@psmyrek psmyrek mentioned this issue Mar 17, 2022
Merged
@psmyrek
Copy link
Contributor

psmyrek commented Mar 17, 2022

Issues for upgrading Karma have been created:

pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Mar 18, 2022
@pomek
Merge pull request #763 from ckeditor/ck/11337
bd5e23c 
Other: Bumped Karma test runner to v6.x. Closes ckeditor/ckeditor5#11337.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 18, 2022
@CKEditorBot CKEditorBot added this to the iteration 52 milestone Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 52 (v34.0.0)
Development

Successfully merging a pull request may close this issue.

Bumped Karma to v6.x ckeditor/ckeditor5-dev
3 participants
@pomek @CKEditorBot @psmyrek