Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after getting data with code block in list #11354

Closed
LukaszGudel opened this issue Feb 28, 2022 · 2 comments
Closed

Error after getting data with code block in list #11354

LukaszGudel opened this issue Feb 28, 2022 · 2 comments
Labels
package:code-block package:list resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@LukaszGudel
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Switch to ck/10812-document-list-editing.
  2. Open documentlist manual test.
  3. Select "Second" word and turn it into code block.
  4. Call editor.getData()

or

  1. Select a single line list item.
  2. Change it to code block.
  3. Add something after the code block in the same bullet point.
  4. Call editor.getData().

✔️ Expected result

Editor data is returned.

❌ Actual result

Error on editor.getData() in the console:

emittermixin.js:233 Uncaught TypeError: Cannot read properties of undefined (reading 'name')
    at Mapper.getModelLength (mapper.js:531:1)
    at Mapper.findPositionIn (mapper.js:595:1)
    at Mapper.on.priority (mapper.js:129:1)
    at Mapper.fire (emittermixin.js:200:1)
    at Mapper.toViewPosition (mapper.js:380:1)
    at DowncastDispatcher.<anonymous> (converters.js:403:1)
    at DowncastDispatcher.fire (emittermixin.js:200:1)
    at DowncastDispatcher._testAndFire (downcastdispatcher.js:549:1)
    at DowncastDispatcher._convertInsert (downcastdispatcher.js:295:1)
    at DowncastDispatcher.convert (downcastdispatcher.js:203:1)
@LukaszGudel LukaszGudel added type:bug This issue reports a buggy (incorrect) behavior. package:list package:code-block squad:core Issue to be handled by the Core team. labels Feb 28, 2022
@Reinmar
Copy link
Member

Reinmar commented Mar 2, 2022

On our newest branches (the one for list props) it works fine. I'll keep the ticket open for some time to verify later that we didn't break it again.

@Reinmar
Copy link
Member

Reinmar commented Apr 11, 2022

It's still fixed on latest master.

@Reinmar Reinmar closed this as completed Apr 11, 2022
@Reinmar Reinmar added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:code-block package:list resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants