Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document list] Stabilization #11377

Closed
Reinmar opened this issue Mar 2, 2022 · 16 comments
Closed

[Document list] Stabilization #11377

Reinmar opened this issue Mar 2, 2022 · 16 comments
Labels
Epic package:list resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 2, 2022

Stabilization phase for #2973.

ToC:

@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. Epic labels Mar 2, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 18, 2022
@CatStrategist
Copy link
Contributor

@ckeditor/qa-team

Following issues should be resolved, please test them when you have a chance:
#11386
#11385
#11353
#11532
#11346

@CatStrategist
Copy link
Contributor

@ckeditor/qa-team

Please retest it as a whole feature as well. Not much should have changed since the last tests. Most changes were related to inserting widgets. Branch is the same as the last time ck/11198-make-sure-list-isnt-split.

@FilipTokarski
Copy link
Member

FilipTokarski commented Mar 31, 2022

#11346 - this issue still exists on ck/11198-make-sure-list-isnt-split branch.

EDIT - fixed.

@FilipTokarski
Copy link
Member

FilipTokarski commented Mar 31, 2022

Steps:

  1. Create a list item
  2. In this list item add codeblock
  3. Type foo
  4. Put the cursor at the beginning of the text - []foo
  5. Press backspace

Expected:

List item is removed.

Actual:

Nothing happens, backspace for removing list item works only if you first remove the whole text.

Screencast:

0_list1.mp4

@FilipTokarski
Copy link
Member

Pressing shift+enter in empty list item results in outdenting/removing the list item. I'd assume that it would let me create a new line and type, while being still in the same list item (like in MS Word / Google Docs).

@FilipTokarski
Copy link
Member

FilipTokarski commented Mar 31, 2022

Steps:

  1. Add a few list items, the first one should be a code block
  2. Select the whole content
  3. Change list type

EDIT: this can be simplified - just create list item with code block inside and try changing its list style a few times.

Expected:

List type is changes, bullet styles change accordingly. List structure is preserved.

Actual:

First list item gets indented and changes its styling incorrectly (you can try with roman/latin styles etc.). You need to undo two times to get back to the initial state of the list.

Screencast:

0_list2.mp4

@FilipTokarski
Copy link
Member

Not sure if this was in scope or not, but it would be nice to be able to create a block quote in list item. Currently it splits the list into two separate ones.

@FilipTokarski
Copy link
Member

FilipTokarski commented Apr 1, 2022

Overall the feature looks ok, inserting/removing widgets works much better now 👍

FYI the bugs with code block I reported above occur only when using also TextPartLanguage plugin and have been extracted to separate issues.

@dufipl
Copy link
Contributor

dufipl commented Apr 1, 2022

#11386 is only partially fixed, details in the comment.
Same applies to #11385

@FilipTokarski
Copy link
Member

FilipTokarski commented Apr 1, 2022

Paste and drag&drop are not supported yet as far as I know, so this behaviour is currently expected. Am I right @CatStrategist ?

@dufipl
Copy link
Contributor

dufipl commented Apr 1, 2022

Maybe this would explain why dragging and dropping tables create new list elements:
table drag and drop document list issue

EDIT:
Created the issue to track resolving this: #11546

@CatStrategist
Copy link
Contributor

Paste and drag&drop are not supported yet as far as I know, so this behaviour is currently expected. Am I right @CatStrategist ?

Yes, it still needs some discussion and isn't implemented yet.

@dufipl
Copy link
Contributor

dufipl commented Apr 1, 2022

Added drag and drop/copy-paste feature request aggregating current issues related to this within document lists: #11547

@dufipl
Copy link
Contributor

dufipl commented Apr 22, 2022

Issue related to the positioning of the table in Chrome and Firefox: #11663

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 30, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 12, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 22, 2023
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic package:list resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

5 participants