Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PostCSS to the latest version #11460

Closed
pomek opened this issue Mar 14, 2022 · 4 comments
Closed

Upgrade PostCSS to the latest version #11460

pomek opened this issue Mar 14, 2022 · 4 comments
Assignees
@przemyslaw-zan
Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 52 (v34...

Comments

@pomek
Copy link
Member

pomek commented Mar 14, 2022 •
edited
Loading

Provide a description of the task

@dependabot explains why it is needed in PRs.

Scope

  • Upgrade postcss from 7 to 8.
  • Make sure the following tasks still work:
    • Verify whether ckeditor5-build-* packages are built properly.
    • Verify whether manual tests work.
    • Verify whether automated tests work.
    • Verify whether DLLs work.
    • Verify whether documentation works.
    • Verify whether the content-styles extractor still works.
  • PostCSS is used in many places. Make sure to update all of them:
    • Mentioned ckeditor5 and ckeditor5-dev repositories.
    • Package generator.
    • Online Builder and builds procured by the tool.
  • Create a migration guide on why did we do it.
    This is not needed, it's not a major bump.

Tips

Before starting anything, prepare test scenarios that you can follow before and after upgrading the environment. It will help understand issues you spot.

Content-styles extractor

Our script implements a plugin that iterates over-produced CSS rules. We need to adjust its API. See: 64ffb7b.

Upgrading PostCSS plugins in ckeditor5-dev

In the past, I thought we could support both versions. It does not work as we cannot predict which PostCSS plugins will be installed. Hence, let's support only PostCSS@8: ckeditor/ckeditor5-dev@a3174e6.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. bc:major Resolving this issue will introduce a major breaking change. labels Mar 14, 2022
@pomek pomek mentioned this issue Mar 15, 2022
Closed
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 16, 2022
This was referenced Mar 22, 2022
Merged
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Mar 22, 2022
@pomek
Merge pull request #764 from ckeditor/ck/11460
bda2a8e 
Feature (utils): The `styles.getPostCssConfig()` function returns a configuration compatible with `postcss@8`. See ckeditor/ckeditor5#11460.

MAJOR BREAKING CHANGE (utils): Upgraded the `postcss` version to 8 and marked the package as peer dependency instead of dependency. Starting from this version, when using the `@ckeditor/ckeditor5-dev-utils`, you need to manually install the `postcss` dependency.

Tests (env): Fixed broken tests on Windows.

Tests (env): Fixed deprecation warnings.
@przemyslaw-zan przemyslaw-zan mentioned this issue Mar 22, 2022
Merged
@pomek
Copy link
Member Author

pomek commented Mar 22, 2022

Changes in ckeditor5-dev are released: https://github.com/ckeditor/ckeditor5-dev/releases/tag/v30.0.0.

@pomek pomek removed the bc:major Resolving this issue will introduce a major breaking change. label Mar 22, 2022
pomek added a commit that referenced this issue Mar 22, 2022
@pomek
Merge pull request #11498 from ckeditor/ck/11460
4afb9b1 
Other: CKEditor 5 uses PostCSS@8 now. Closes See #11460.
pomek added a commit to ckeditor/ckeditor5-package-generator that referenced this issue Mar 22, 2022
@pomek
Merge pull request #95 from ckeditor/ck/11460
d57cc3e 
Other: Packages generated by the tool use PostCSS@8 now. See ckeditor/ckeditor5#11460.
This was referenced Mar 22, 2022
Merged
Closed
@pomek
Copy link
Member Author

pomek commented Mar 22, 2022

CKEditor 5 on the #master branch uses PostCSS 8 too.

@pomek
Copy link
Member Author

pomek commented Mar 23, 2022

Starting from the next release, Online Builder will produce builds that use PostCSS 8.

@pomek
Copy link
Member Author

pomek commented Mar 23, 2022

All work done.

@pomek pomek closed this as completed Mar 23, 2022
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 23, 2022
@pomek pomek added this to the iteration 52 milestone Mar 23, 2022
@CKEditorBot CKEditorBot modified the milestones: iteration 52, upcoming Mar 23, 2022
@pomek pomek modified the milestones: upcoming, iteration 52 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslaw-zan przemyslaw-zan

Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 52 (v34.0.0)
Development

No branches or pull requests
3 participants
@pomek @CKEditorBot @przemyslaw-zan