Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking between two adjacent inline formatting regions results in error #11472

Closed
hejinhua opened this issue Mar 16, 2022 · 4 comments · Fixed by #11943
Closed

Clicking between two adjacent inline formatting regions results in error #11472

hejinhua opened this issue Mar 16, 2022 · 4 comments · Fixed by #11943
Assignees
Labels
package:engine squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@hejinhua
Copy link

hejinhua commented Mar 16, 2022

📝 Provide detailed reproduction steps (if any)

  1. use ClassicEditor
  2. Click Bold first, then enter the content
  3. Click the Italic, then enter the content
  4. Click on the junctions of two formats, console err: view-renderer-filler-was-lost

✔️ Expected result

Don't report wrong,can continue editing

❌ Actual result

After the input, the console has been reported.

📃 Other details

This error can also be reproduced by editing the demo on the official website

image

@hejinhua hejinhua added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 16, 2022
@FilipTokarski
Copy link
Member

Hi, I was not able to reproduce this error. Could you provide a screencast to show exactly how to reproduce it? And also what is the editor version that you use?

@FilipTokarski FilipTokarski added the pending:feedback This issue is blocked by necessary feedback. label Mar 16, 2022
@hejinhua
Copy link
Author

2022-03-16.16.40.07.mov

@FilipTokarski
Copy link
Member

FilipTokarski commented Mar 16, 2022

Thanks! I can reproduce it now as well. Looks like it was introduced in version 31.0.0.

This happens between two adjacent inline formatting regions and can be reproduced with other plugins also.

Uncaught CKEditorError: view-renderer-filler-was-lost
Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-view-renderer-filler-was-lost
    at Renderer._removeInlineFiller (renderer.js:445:1)
    at Renderer.render (renderer.js:217:1)
    at Renderer.<anonymous> (renderer.js:128:1)
    at Renderer.fire (emittermixin.js:199:1)
    at Renderer.set [as isSelecting] (observablemixin.js:95:1)
    at updateBoundObservableProperty (observablemixin.js:663:1)
    at observablemixin.js:690:1
    at Set.forEach (<anonymous>)
    at Object.<anonymous> (observablemixin.js:689:1)
    at Object.fire (emittermixin.js:199:1)

@FilipTokarski FilipTokarski added squad:core Issue to be handled by the Core team. and removed pending:feedback This issue is blocked by necessary feedback. labels Mar 16, 2022
@FilipTokarski FilipTokarski changed the title view-renderer-filler-was-lost Clicking between two adjacent inline formatting regions results in error Mar 16, 2022
@FilipTokarski FilipTokarski added package:engine type:regression This issue reports a bug that was not present in the previous releases. labels Mar 16, 2022
@hubertperron
Copy link

hubertperron commented Jun 20, 2022

This is still present in CKEditor v34 but doesn't seem to break any functionality besides filling our error monitoring with tons of exceptions ;)

@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 21, 2022
@niegowski niegowski self-assigned this Jun 21, 2022
arkflpc added a commit that referenced this issue Jun 21, 2022
Fix (engine): Inline filler should not be removed while updating a text node. Closes #11472.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 21, 2022
@CKEditorBot CKEditorBot added this to the iteration 54 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants