Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS MVP] Rewrite ckeditor5-engine #11724

Closed
arkflpc opened this issue May 6, 2022 · 2 comments · Fixed by #12188
Closed

[TS MVP] Rewrite ckeditor5-engine #11724

arkflpc opened this issue May 6, 2022 · 2 comments · Fixed by #12188
Assignees
@oleq @arkflpc
Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 56 (v35...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented May 6, 2022 •
edited
Loading

Rewrite ckeditor5-engine to TypeScript.

Make sure that automated and manual tests run after the rewrite. Tests themselves are out of scope.

This would be the first serious application of EmitterMixing and typing of Emitter done in #11715.

Part of #11708.
@arkflpc arkflpc added squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". domain:ts and removed type:task This issue reports a chore (non-production change) and other types of "todos". labels May 6, 2022
@arkflpc
Copy link
Contributor Author

arkflpc commented May 23, 2022

Let's try to think about Emitter being more statically typed.

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 7, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 9, 2022
@oleq oleq self-assigned this Jun 23, 2022
@arkflpc arkflpc mentioned this issue Jul 5, 2022
Closed
@Reinmar Reinmar mentioned this issue Jul 21, 2022
Closed
@arkflpc arkflpc mentioned this issue Aug 1, 2022
Merged
pomek added a commit that referenced this issue Aug 4, 2022
@pomek
Merge pull request #12188 from ckeditor/ck/11724-ts-engine
dd14cd2 
Other (engine): Rewrite `ckeditor5-engine` package to TypeScript. Closes #11724.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 4, 2022
@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 4, 2022
@Inviz
Copy link
Contributor

Inviz commented Sep 9, 2022

nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

@arkflpc arkflpc

Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 56 (v35.1.0)
Development

Successfully merging a pull request may close this issue.

Ck/11724 ts engine ckeditor/ckeditor5
4 participants
@Inviz @oleq @arkflpc @CKEditorBot