Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove highlight applies the currently chosen highlight type instead or removing it #12265

Closed
FilipTokarski opened this issue Aug 12, 2022 · 2 comments · Fixed by #12289
Closed

Remove highlight applies the currently chosen highlight type instead or removing it #12265

FilipTokarski opened this issue Aug 12, 2022 · 2 comments · Fixed by #12289
Assignees
@arkflpc
Labels
package:highlight squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Milestone
iteration 56 (v35...

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/docs/ckeditor5/latest/features/highlight.html
  2. Try to remove highlight on any selection

It was introduced in version 35

✔️ Expected result

Highlight is removed.

❌ Actual result

Screen.Recording.2022-08-12.at.09.29.28.mov

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:highlight type:regression This issue reports a bug that was not present in the previous releases. squad:core Issue to be handled by the Core team. labels Aug 12, 2022
@FilipTokarski FilipTokarski mentioned this issue Aug 12, 2022
Closed
@Reinmar
Copy link
Member

Reinmar commented Aug 17, 2022

This regression is probably caused by the changes introduced in #12125 (see the explanation that we wrote down there). However, I'd recommend bisecting first.

@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 17, 2022
@arkflpc arkflpc self-assigned this Aug 18, 2022
@arkflpc
Copy link
Contributor

arkflpc commented Aug 18, 2022

The first bad commit is 618bb41

@arkflpc arkflpc mentioned this issue Aug 18, 2022
Merged
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 22, 2022
@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 22, 2022
@Reinmar Reinmar mentioned this issue Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
package:highlight squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
iteration 56 (v35.1.0)
Development

Successfully merging a pull request may close this issue.

Fixes 'Remove highlight' ckeditor/ckeditor5
4 participants
@Reinmar @arkflpc @CKEditorBot @FilipTokarski