Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 'Remove highlight' #12289

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Fixes 'Remove highlight' #12289

merged 3 commits into from
Aug 22, 2022

Conversation

arkflpc
Copy link
Contributor

@arkflpc arkflpc commented Aug 18, 2022

Suggested merge commit message (convention)

Fix (highlight): Restores correct functionality of "Remove highlight" toolbar button. Closes #12265.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@oleq oleq self-requested a review August 18, 2022 14:01
@Reinmar
Copy link
Member

Reinmar commented Aug 19, 2022

cc @ckeditor/qa-team Could you test it?

Please make sure that it didn't regress the focus management (that the focus lands in the editing area after a style is applied).

@Acrophost
Copy link

Tested on multiple browsers and editor types, everything seems to be working fine.
The only issue is focus with grouped toolbar, but fix for #12178 should cover it.

@Reinmar Reinmar requested review from Dumluregn and removed request for oleq August 22, 2022 11:44
@Dumluregn Dumluregn merged commit 80440eb into master Aug 22, 2022
@Dumluregn Dumluregn deleted the ck/12265 branch August 22, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove highlight applies the currently chosen highlight type instead or removing it
4 participants